"hello world" app again doesn't quit when I close its window

mozilla / positron

a experimental, Electron-compatible runtime on top of Gecko

Other

564 stars 64 forks source link

"hello world" app again doesn't quit when I close its window #38

Closed mykmelez closed 8 years ago

mykmelez commented 8 years ago

@jryans After merging from upstream in #37, Hello World again doesn't quit when I close its window, so upstream appears to have regressed your fix for #29.

jryans commented 8 years ago

Okay, I'll take a look!

jryans commented 8 years ago

I checked Linux tonight and it seems to be working. I'll take a look at Windows tomorrow. @mykmelez, what OS were you testing?

mykmelez commented 8 years ago

I'm testing on Mac!

jryans commented 8 years ago

@mykmelez, I thought it's not supposed to quit on Mac though? Maybe I am forgetting what it did before... The test app skips quitting on Mac I thought: https://github.com/mozilla/positron/blob/master/positron/test/hello-world/main.js#L11-L18

mykmelez commented 8 years ago

OMG, of course. 🐑ish, :chagrined:, :contrite:, where are all the complex-emotion emoji when you need them? Sorry for wasting your time, @jryans!

jryans commented 8 years ago

No worries, it's kind of confusing! 😄