search

mozilla / positron

a experimental, Electron-compatible runtime on top of Gecko
Other
564 stars 64 forks source link

Pass args to apply `all` window feature #53

Closed jryans closed 8 years ago

jryans commented 8 years ago

Instead of #52, we could take this approach to be more like Firefox's behavior.

So, for the "all" feature to apply correctly, openWindow must consider you to be a dialog, where that is apparently defined as "passed a non-zero length args array".

And sure enough, Firefox's nsBrowserContentHandler.js has an openWindow wrapper which seems to create an args array and add at least one element down each of its various paths.

Perhaps it's best to match Firefox since this should enable many features, instead of listing them one by one.

jryans commented 8 years ago

@mykmelez, what do you think about this instead of #52?

mykmelez commented 8 years ago

Pave the cowpaths! Although in this case it's more like: travel the cowpaths, which may one day be paved, even though they're mined with dung (so mind the dung).

mykmelez commented 8 years ago

@mykmelez, what do you think about this instead of #52?

To be less oblique: I like this solution much better, since it follows the existing convention, and is thus less likely to break (and as a beneficial side effect fixes other things that I haven't noticed are broken yet). It's only unfortunate that it requires the code to do unnecessary work to create an nsISupportsArray and populate it with a null element.

mykmelez commented 8 years ago

(and as a beneficial side effect fixes other things that I haven't noticed are broken yet)

Among other things, it enables fullscreen mode for the window, so you can give it the absolute maximum screen real estate available when doing intense debugging. FTW!