mozilla / positron

a experimental, Electron-compatible runtime on top of Gecko
Other
562 stars 64 forks source link

complete support for Electron webview load-commit event #70

Open mykmelez opened 8 years ago

mykmelez commented 8 years ago

The webview-element branch #60 equates the webview event load-commit, as described in Electron webview docs, with the mozbrowser event mozbrowserlocationchange.

That might be correct, for the top-level frame, anyway, even though WebAPI/BrowserAPI/Common_Subset equates that event with the mozbrowserloadend.

But mozbrowserlocationchange doesn't appear to fire for sub-frame loads, whereas load-commit apparently does. And I haven't yet confirmed that the events are equivalent even for the top-frame load. Also, the implementation doesn't yet set the url and isMainFrame properties of the event object.

So we still need to implement complete support for the load-commit event.