Ensure remote iframes don't get the system principal.

mozilla / positron

a experimental, Electron-compatible runtime on top of Gecko

Other

562 stars 64 forks source link

Closed brendandahl closed 8 years ago

brendandahl commented 8 years ago

After some careful log review of remote=true/false, I saw that there were some NS_FAILED that'd didn't occur on remote=false. After checking those out, I tracked the failure down to https://github.com/mozilla/gecko-dev/blob/965dbc5745f2dd40106a3e075ab8d3ef284c0aa6/caps/nsSystemPrincipal.cpp#L73

Turns out our hack to give system principal to the top document was also giving it to the remote iframe.

brendandahl commented 8 years ago

Fixes #76

mykmelez commented 8 years ago

Yikes, nice catch!