search

mozilla / positron

a experimental, Electron-compatible runtime on top of Gecko
Other
562 stars 64 forks source link

Track the url of remote iframes. #95

Closed brendandahl closed 8 years ago

brendandahl commented 8 years ago

The sample browser app still leaves a bit to be desired, but it seems to also have issues with electron as well (I see "undefined" flashed in the url bar when loading and changing pages).

Fixes #92

mykmelez commented 8 years ago

The sample browser app still leaves a bit to be desired, but it seems to also have issues with electron as well (I see "undefined" flashed in the url bar when loading and changing pages).

Indeed. Another issue I've noticed is that the page width is greater than the window width, so a horizontal scrollbar appears, which you can use to scroll the <webview> slightly out of view. That happens in both Positron and Electron.

It might be worth contributing changes to that app to make it a better demo, since it's currently our demo app for Positron. We could even import it into our repository (or make it a submodule, perhaps forking it first so we can iterate more quickly than upstream). Provided we don't specialize it for Positron unintentionally.