search

mozilla / price-tracker

Price Tracker is a Firefox extension that spots price drops on things you’re interested in.
https://addons.mozilla.org/en-US/firefox/addon/price-tracker/
Mozilla Public License 2.0
53 stars 17 forks source link

Require manual approval to upload XPI files to Test Pilot. #285

Closed Osmose closed 5 years ago

Osmose commented 5 years ago

This will allow us to do release builds of the add-on and send them to QA for testing before we actually upload them.

Osmose commented 5 years ago

Or is the goal to test and verify the signed add-on before releasing it?

That's the goal. QA needs to verify the exact artifact we're sending to users. Unfortunately testing with the staging key doesn't work on Release, so if we want reliable release-level testing, we need to sign for release.

Note that signing is only done when someone pushes a tag of the form v1.0.0 so there is some level of intentionality behind it already.