mozilla / price-tracker

Price Tracker is a Firefox extension that spots price drops on things you’re interested in.
https://addons.mozilla.org/en-US/firefox/addon/price-tracker/
Mozilla Public License 2.0
53 stars 17 forks source link

What should the extension do when there is not a single price on a product page? #86

Open sharonbautista opened 6 years ago

sharonbautista commented 6 years ago

I initially set an alert for the 400ml version of this watering can: https://www.amazon.com/dp/B06X6FSJNP/ref=sspa_dk_detail_0?pd_rd_i=B06WRQPNJ4&pf_rd_m=ATVPDKIKX0DER&pf_rd_p=a54d13fc-b8a1-4ce8-b285-d77489a09cf6&pf_rd_r=7MC0VQSVZZFDYAS9KBZ4&pd_rd_wg=PNtEh&pf_rd_s=desktop-dp-sims&pf_rd_t=40701&pd_rd_w=tKkis&pf_rd_i=desktop-dp-sims&pd_rd_r=586b96ae-ac7f-11e8-861c-cd06ea1130b1&th=1

I was able to create that 400ml watering can alert as expected. When I went to view the 900ml version of that watering can, the extension would not detect the page (900ml can is page being viewed; 400ml can is reflected in alert panel):

screen shot 2018-08-30 at 1 13 42 pm

This instance raises a few questions:

biancadanforth commented 6 years ago

Thank you Sharon; you raise an important semantic and product question:

This page and others, like the Etsy page in #88 and the Macy's page and Walmart page in #79 do not represent a single product but a class of products with an often implicit range of prices.

From a technical point of view, we don't know how to determine what the correct price is, since pages like these violate our extension's assumption that there is a single product on a product page. We also wouldn't know how to update the prices in the background in many cases, since the URLs for sites like Etsy (example) may not change to reflect that the user selected a particular variation.

Edit: Going to rename this issue to be more reflective of the question it raises. Also related: #43 .

javaun commented 6 years ago

This is a super important conversation -- and why we need to be in Test Pilot. First, we can move this beyond the MVP and ship as-is. We'll get some helpful user feedback.

We can backlog this one for post-MVP and think about it in multiple contexts. This one straddles not just a large body of work that would fit under "fathom improvement" but also general UI improvements.

brucko commented 6 years ago

We likely can learn from other extensions like Honey how they handle some of these edge cases for guidance on how to handle. 

On Wed, Sep 19, 2018 at 2:06 PM, Javaun Moradi < notifications@github.com > wrote:

This is a super important conversation -- and why we need to be in Test Pilot. First, we can move this beyond the MVP and ship as-is. We'll get some helpful user feedback.

We can backlog this one for post-MVP and think about it in multiple contexts. This one straddles not just a large body of work that would fit under "fathom improvement" but also general UI improvements.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub ( https://github.com/mozilla/webext-commerce/issues/86#issuecomment-422958464 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AJQPSC3vjxWdJ44xxKIV8Csbm4ImYMI6ks5ucrHDgaJpZM4WT-he ).