mozilla / probe-dictionary

Tool that makes Firefox Telemetry probe information searchable
https://probes.telemetry.mozilla.org
Mozilla Public License 2.0
7 stars 17 forks source link

Wrong info around browser.ui.interaction.preferences_paneSearch #125

Closed xluo-ds closed 1 year ago

xluo-ds commented 3 years ago

https://probes.telemetry.mozilla.org/?search=browser+ui+search&view=detail&probeId=scalar%2Fbrowser.ui.interaction.preferences_paneSearch

Not sure whether it's meant this way. In the above link it's said to be a scalar, but actually a keyed-scalar in main (link)

jklukas commented 3 years ago

This does seem to be the case for keyed scalars in general in the probe dictionary. So this bug is not limited to just this one keyed scalar.

fbertsch commented 3 years ago

It's almost definitely getting the type from the top-level type field, whereas keyed is buried deep in the details (root.history.release[0].details.keyed). Seems like it should be a straightforward fix to also check the latest details.

Iinh commented 1 year ago

Fixed by #128.