search

mozilla / probe-dictionary

Tool that makes Firefox Telemetry probe information searchable
https://probes.telemetry.mozilla.org
Mozilla Public License 2.0
7 stars 17 forks source link

Search.content probes should be labeled as keyed_scalars #127

Closed mmccorks closed 1 year ago

mmccorks commented 1 year ago

The probes https://probes.telemetry.mozilla.org/?search=search.content are all set to type scalars but are actually found in keyed_scalars - the link to query them in telemetry.main therefore does not work.

chutten commented 1 year ago

I confirm that the data in all_probes is coming back identifying it as a scalar not a keyed_scalar, so this'll be a bug in the probe info service, not the Probe Dictionary itself:

"scalar/browser.search.content.about_home": {
    "first_added": {
      "beta": "2021-04-19 23:47:47",
      "nightly": "2021-03-31 11:31:43",
      "release": "2021-05-25 01:28:27"
    },
    "history": {
      "beta": [
        {
          "bug_numbers": [
            1089670,
            1475571,
            1482158,
            1545172,
            1634564
          ],
          "cpp_guard": null,
          "description": "Records counts for in-content searches where the search was most likely started from the about:home. The key format is <provider>:[tagged|tagged-follow-on|organic]:[code|none]\n",
          "details": {
            "keyed": true,
            "kind": "uint",
            "record_in_processes": [
              "main"
            ],
            "record_into_store": [
              "main"
            ]
          },
          "expiry_version": "never",
          "notification_emails": [
            "fx-search-telemetry@mozilla.com",
            "rev-data@mozilla.com"
          ],
          "optout": true,
          "revisions": {
            "first": "ff6aefbc9eb1d58bfcc3dcdddeafa326b4d5da06",
            "last": "929ba7a43e547e2dccb5e2bc1d6e21d9e8064e7e"
          },
          "versions": {
            "first": "103",
            "last": "105"
          }
        },
        {
          "bug_numbers": [
            1089670,
            1475571,
            1482158,
            1545172,
            1634564
          ],
          "cpp_guard": null,
          "description": "Records counts for in-content searches where the search was most likely started from the about:home. The key format is <provider>:[tagged|tagged-follow-on|organic]:[code|none]\n",
          "details": {
            "keyed": true,
            "kind": "uint",
            "record_in_processes": [
              "main"
            ],
            "record_into_store": [
              "main"
            ]
          },
          "expiry_version": "never",
          "notification_emails": [
            "fx-search@mozilla.com",
            "rev-data@mozilla.com"
          ],
          "optout": true,
          "revisions": {
            "first": "a7294bfb43712ab3225c76087cd359a22ea8fa7d",
            "last": "a7294bfb43712ab3225c76087cd359a22ea8fa7d"
          },
          "versions": {
            "first": "102",
            "last": "102"
          }
        },
        {
          "bug_numbers": [
            1089670,
            1475571,
            1482158,
            1545172,
            1634564
          ],
          "cpp_guard": null,
          "description": "Records counts for in-content searches where the search was most likely started from the about:home. The key format is <provider>:[tagged|tagged-follow-on|organic]:[code|none]\n",
          "details": {
            "keyed": true,
            "kind": "uint",
            "record_in_processes": [
              "main"
            ],
            "record_into_store": [
              "main"
            ]
          },
          "expiry_version": "never",
          "notification_emails": [
            "fx-search-telemetry@mozilla.com",
            "rev-data@mozilla.com"
          ],
          "optout": true,
          "revisions": {
            "first": "f3185e137745bef8c6c463c5c6b75e20568c5fdf",
            "last": "e8e192469cf4132063f3172f3140e2042b2a0276"
          },
          "versions": {
            "first": "103",
            "last": "103"
          }
        },
        {
          "bug_numbers": [
            1089670,
            1475571,
            1482158,
            1545172,
            1634564
          ],
          "cpp_guard": null,
          "description": "Records counts for in-content searches where the search was most likely started from the about:home. The key format is <provider>:[tagged|tagged-follow-on|organic]:[code|none]\n",
          "details": {
            "keyed": true,
            "kind": "uint",
            "record_in_processes": [
              "main"
            ],
            "record_into_store": [
              "main"
            ]
          },
          "expiry_version": "never",
          "notification_emails": [
            "fx-search@mozilla.com",
            "rev-data@mozilla.com"
          ],
          "optout": true,
          "revisions": {
            "first": "2cd99c728148493e0ee78c765d53a4ca40638c61",
            "last": "b6b2b8930fdfb037e4a743d0ac722a1f2b1b1447"
          },
          "versions": {
            "first": "89",
            "last": "102"
          }
        }
      ],
      "nightly": [
        {
          "bug_numbers": [
            1089670,
            1475571,
            1482158,
            1545172,
            1634564
          ],
          "cpp_guard": null,
          "description": "Records counts for in-content searches where the search was most likely started from the about:home. The key format is <provider>:[tagged|tagged-follow-on|organic]:[code|none]\n",
          "details": {
            "keyed": true,
            "kind": "uint",
            "record_in_processes": [
              "main"
            ],
            "record_into_store": [
              "main"
            ]
          },
          "expiry_version": "never",
          "notification_emails": [
            "fx-search-telemetry@mozilla.com",
            "rev-data@mozilla.com"
          ],
          "optout": true,
          "revisions": {
            "first": "0242545b34ca3f3290c68496c2e921ddfdf5cdc3",
            "last": "c7037dbd2de37f147a445b6dae361671ef71896a"
          },
          "versions": {
            "first": "103",
            "last": "106"
          }
        },
        {
          "bug_numbers": [
            1089670,
            1475571,
            1482158,
            1545172,
            1634564
          ],
          "cpp_guard": null,
          "description": "Records counts for in-content searches where the search was most likely started from the about:home. The key format is <provider>:[tagged|tagged-follow-on|organic]:[code|none]\n",
          "details": {
            "keyed": true,
            "kind": "uint",
            "record_in_processes": [
              "main"
            ],
            "record_into_store": [
              "main"
            ]
          },
          "expiry_version": "never",
          "notification_emails": [
            "fx-search@mozilla.com",
            "rev-data@mozilla.com"
          ],
          "optout": true,
          "revisions": {
            "first": "142544e13e2942ddd3035a3d9db5d739e0a7d392",
            "last": "fa042bbf4c143ee21fb05b382706cf3a2219a4e2"
          },
          "versions": {
            "first": "89",
            "last": "103"
          }
        }
      ],
      "release": [
        {
          "bug_numbers": [
            1089670,
            1475571,
            1482158,
            1545172,
            1634564
          ],
          "cpp_guard": null,
          "description": "Records counts for in-content searches where the search was most likely started from the about:home. The key format is <provider>:[tagged|tagged-follow-on|organic]:[code|none]\n",
          "details": {
            "keyed": true,
            "kind": "uint",
            "record_in_processes": [
              "main"
            ],
            "record_into_store": [
              "main"
            ]
          },
          "expiry_version": "never",
          "notification_emails": [
            "fx-search-telemetry@mozilla.com",
            "rev-data@mozilla.com"
          ],
          "optout": true,
          "revisions": {
            "first": "5c3227d2de55585def91bf8c3eb60794c3865b87",
            "last": "929ba7a43e547e2dccb5e2bc1d6e21d9e8064e7e"
          },
          "versions": {
            "first": "103",
            "last": "105"
          }
        },
        {
          "bug_numbers": [
            1089670,
            1475571,
            1482158,
            1545172,
            1634564
          ],
          "cpp_guard": null,
          "description": "Records counts for in-content searches where the search was most likely started from the about:home. The key format is <provider>:[tagged|tagged-follow-on|organic]:[code|none]\n",
          "details": {
            "keyed": true,
            "kind": "uint",
            "record_in_processes": [
              "main"
            ],
            "record_into_store": [
              "main"
            ]
          },
          "expiry_version": "never",
          "notification_emails": [
            "fx-search@mozilla.com",
            "rev-data@mozilla.com"
          ],
          "optout": true,
          "revisions": {
            "first": "f62a712208b3368f415c5b96260a366c16e9b637",
            "last": "a7294bfb43712ab3225c76087cd359a22ea8fa7d"
          },
          "versions": {
            "first": "89",
            "last": "102"
          }
        }
      ]
    },
    "name": "browser.search.content.about_home",
    "type": "scalar"
  },

Lemme file a bug in probe-scraper about this.

Iinh commented 1 year ago

This'll be a bug in the probe info service, not the Probe Dictionary itself:

This seems like a bug in the Probe Dictionary as well. scalars is hard-coded to the STMO links for all scalars, without checking if it's keyed or not. See: https://github.com/mozilla/probe-dictionary/blob/main/src/components/probeDetails.jsx#L128

I doubled checked for keyed histograms and looks like we have the same bug there. For example, URLCLASSIFIER_CL_KEYED_UPDATE_TIME is a keyed histogram and available in payload.keyed_histograms.urlclassifier_cl_keyed_update_time, but Probe Dictionary says that it is in payload.histograms.urlclassifier_cl_keyed_update_time, which is wrong.

chutten commented 1 year ago

Oh, I see. So the type will always be scalar, not ever keyed_scalar and it involves dipping into the history to find out if it's ever been or still is keyed? I'll close the probeinfo issue.