search

mozilla / probe-dictionary

Tool that makes Firefox Telemetry probe information searchable
https://probes.telemetry.mozilla.org
Mozilla Public License 2.0
7 stars 17 forks source link

Differentiate keyed probes from regular probes #128

Closed Iinh closed 2 years ago

Iinh commented 2 years ago

Make it more clear when a probe is keyed and get the correct BigQuery tables for keyed probes. Also fixes #127, #125, #121.

chutten commented 2 years ago

Would it be within scope to also adjust to call them keyed scalar and keyed histogram in the search results table as well?

And to fix the Keyed: field in the detail view (which is currently empty

Iinh commented 2 years ago

Would it be within scope to also adjust to call them keyed scalar and keyed histogram in the search results table as well? And to fix the Keyed: field in the detail view (which is currently empty.

Yup within scope. I'll add them to the fix.

Iinh commented 2 years ago

I decided to add a new field to the JSON data called detailed_type to be shown in search and probe detail page (mutating the current type field to include the word "keyed" where applicable breaks things because we use it in various places).

The new search page includes the detailed types:

CleanShot 2022-09-14 at 13 01 42@2x

Keyed scalar detail page:

CleanShot 2022-09-14 at 13 00 38@2x

Keyed histogram page:

CleanShot 2022-09-14 at 13 01 11@2x
Iinh commented 2 years ago

Will check on stage to make sure everything works fine before doing a prod deployment.