Open georgf opened 7 years ago
I want to Work on this. You can guide me. This is my first bug.
Hey @sannanansari , hi and welcome!
One possible approach for doing this is the following:
revisions
, here.transform
method so that it counts the number of probes per type, per channel and returns a structure with the data.Does this make sense?
Sorry for late. You can elaborate about 1st point.
revisions
is a dictionary.
We want to count the number of entries (or keys) in it (so we can later print it).
I am getting some error.
ERROR:--
Unable to parse whitelist (C:\Users\Sannan Ansari\Documents\GitHub\probe-scraper\probe_scraper\parsers\third_party\histogram-whitelists.json). Assuming all histograms are acceptable.
Traceback (most recent call last):
File "runner.py", line 19, in
All git commands will error until this is rectified.
This initial warning can be silenced or aggravated in the future by setting the $GIT_PYTHON_REFRESH environment variable. Use one of the following values:
Example: export GIT_PYTHON_REFRESH=quiet
The first part ("unable to parse whitelist") is just a warning and expected.
The second part about git is the important one. It sounds like you either 1) don't have git installed or 2) it's not in the path like pointed out in the message.
You could:
python probe_scraper/runner.py --only-moz-central-probes --dry-run
$PATH
etc.Their is no file name(histogram-whitelists.json). So, how can it take any file which is not their as input. What is a whitelist?
You can ignore that first part about "histogram-whitelists.json", it is expected and the code will run fine without this file. A whitelist is a general concept. Here it is used to allow some backward compability for only specific entries, but only when this is run when building Firefox. As mentioned, for this issue you don't need to worry about the whitelist.
I made a pull request You can review it.
To make it more easy to judge whether things worked correctly etc., it would be great to print some basic stats before saving the outputs to disk in runner.py. E.g.: