search

mozilla / probe-scraper

Scrape and publish Telemetry probe data from Firefox
https://mozilla.github.io/probe-scraper/
Mozilla Public License 2.0
21 stars 53 forks source link

change mozillavpn_cirrus to mozillavpn_backend_cirrus #670

Closed Marlene-M-Hirose closed 8 months ago

Marlene-M-Hirose commented 9 months ago

change app_name, app_id, and v1_name in repositories.yaml

badboy commented 9 months ago

This will create new tables, won't it? But they are empty, so we can just drop them and I assume data, if any, has already been sent with the updated app ID anyway? (Only other thing then is that we're now running into the change freeze today)

sean-rose commented 9 months ago

This will create new tables, won't it? But they are empty, so we can just drop them and I assume data, if any, has already been sent with the updated app ID anyway? (Only other thing then is that we're now running into the change freeze today)

Yes, the live & stable tables for the mozillavpn_cirrus app ID are still empty.

The DE change freeze does specifically call out "no new Glean apps", which this app rename would technically qualify as, so I guess this will have to wait until Jan 3 (sorry @brizental).

yashikakhurana commented 8 months ago

@sean-rose just wondering can we merge this now?

sean-rose commented 8 months ago

@sean-rose just wondering can we merge this now?

In terms of the change freeze we're clear to merge, but we still need a code owner to approve this PR. I've asked in Slack.