Closed badboy closed 6 months ago
@badboy isn't Pine deprecated? If so, should we even be doing this?
It fails right now and this should help it getting unstuck. Right now the dupe checks do not check the deprecated flag. I think we can add a check there, but this PR here was the quicker way to ensure we can land that today without further help.
gnaaaah, it's actually a bit more complicated. We moved toolkit/xre/metrics.yaml
from firefox-desktop
to gecko
I think I know what's going on (and this is a hassle to clean up now):
gecko.build_id
and gecko.version
landed in toolkit/xre/metrics.yaml
toolkit/xre/metrics.yaml
was listed for firefox-desktop
(and pine
). It was thus considered a new metric for those appsWe know that the metric is not actually duplicated, so everything should be fine. We just need to teach probe-scraper that. We could "hack" it by just skipping that specific metric for those specific applications. It's an ugly hack. I'm checking if there's a better reliable way to do this now.
python -u -m probe_scraper.runner --dry-run --cache-dir tmp/cache --out-dir tmp/out --glean --update --glean-repo gecko --glean-repo pine --glean-repo firefox-desktop --output-bucket=gs://probe-scraper-prod-artifacts/ --glean-limit-date 2024-02-18
works now with those 2 commits. I dislike everything about the second commit, but I have no better way to cleanly tackle this today.
Seems that does the trick.