search

mozilla / probe-scraper

Scrape and publish Telemetry probe data from Firefox
https://mozilla.github.io/probe-scraper/
Mozilla Public License 2.0
21 stars 53 forks source link

Remove dupe-metric hack #697

Open badboy opened 6 months ago

badboy commented 6 months ago

I added a hack to get firefox-desktop to work properly again: https://github.com/mozilla/probe-scraper/blob/5717fce6ddcf5ce103cd7e47414c348547cf8651/probe_scraper/glean_checks.py#L19-L25

We should find a way that this is not necessary. It shouldn't. The metric is moved from the app to the library.

BenWu commented 5 months ago

This looks like it could be a similar issue that caused https://github.com/mozilla/probe-scraper/issues/711 so I'll append to this one. In that case, the metrics file was removed from mozillavpn_backend_cirrus and nimbus-cirrus was added as a dependency so in that case removing the metrics worked