Set commits_by_repo with repo name before skipping commits

mozilla / probe-scraper

Scrape and publish Telemetry probe data from Firefox

https://mozilla.github.io/probe-scraper/

Mozilla Public License 2.0

21 stars 53 forks source link

Set commits_by_repo with repo name before skipping commits #712

Closed BenWu closed 5 months ago

BenWu commented 5 months ago

Follow-up to #708. This currently fails for repos with no ping/metrics/tag files because it fails the schema validation in glean_checks.check_glean_metric_structure due to no items in commits_by_repo. This initializes commits_by_repo to {"repo_name": {}} instead of an empty dict. Alternative is to allow an empty dict but I think it makes more sense to list the repos explicitly with no commits to scrape. Output is the same either way

BenWu commented 5 months ago

@badboy Do you mind reviewing as a code owner?