search

mozilla / probe-scraper

Scrape and publish Telemetry probe data from Firefox
https://mozilla.github.io/probe-scraper/
Mozilla Public License 2.0
21 stars 53 forks source link

Bug 1874935 - Add new glean-server library to define pings for server-side Glean #717

Closed badboy closed 5 months ago

badboy commented 5 months ago

Right now this just re-uses the Glean SDK repo and its defintions of all builtin pings. Technically server-side Glean would only send the events ping.

Should we:

  1. Create a server-side-pings.yaml in the Glean SDK to reference here?
  2. Create a server-side-pings.yaml in the glean_parser repo to reference here (as that's where all the code for server-side lives)
  3. Create a mozilla/glean-server repository that only exists for that file?
akkomar commented 5 months ago

I think either of the alternative options is preferable over reusing glean-core/pings.yaml to avoid showing unused pings in Glean Dictionary. Since the server component does not use the SDK I'd lean towards option 2, but they all seem fine and are easy to change later.

badboy commented 5 months ago 
python3 -m probe_scraper.runner --dry-run --cache-dir tmp/cache --out-dir tmp/out --glean --glean-limit-date 2024-04-01 --output-bucket=gs://probe-scraper-prod-artifacts/ --glean-repo glean-server --glean-repo accounts-backend --glean-repo moso-mastodon-backend

looking good.