search

mozilla / probe-scraper

Scrape and publish Telemetry probe data from Firefox
https://mozilla.github.io/probe-scraper/
Mozilla Public License 2.0
21 stars 53 forks source link

Bug 1894172 - Add geoip skipping to MDN #736

Closed Dexterp37 closed 3 months ago

Dexterp37 commented 3 months ago

See https://bugzilla.mozilla.org/show_bug.cgi?id=1894172 for more info.

@akkomar how can we make sure this will produce the right results?

akkomar commented 3 months ago

@akkomar how can we make sure this will produce the right results?

Easiest would be to check the distribution of distinct metadata.geo.country, metadata.geo.city in the events ping after this change is picked up by the pipeline (tomorrow by default).

One caveat is that the parameter value might depend on the proxy configuration used by MDN. IIRC when we were rolling this out for accounts_frontend, we were expecting 2 entries need to be skipped, but eventually had to switch to 1. I think the reason was some difference between FxA's load balancer configuration and the one we used while testing this feature earlier. Since in this case geo-decoded data is already broken I wouldn't worry about this and just go with the value proposed in this PR.