search

mozilla / probe-scraper

Scrape and publish Telemetry probe data from Firefox
https://mozilla.github.io/probe-scraper/
Mozilla Public License 2.0
21 stars 53 forks source link

Add explicit retention to all glean apps #771

Closed whd closed 3 months ago

whd commented 3 months ago

https://mozilla-hub.atlassian.net/browse/SRELEAD-182?focusedCommentId=897713

whd commented 3 months ago

Deployment plan in https://mozilla-hub.atlassian.net/browse/SRELEAD-182?focusedCommentId=901771

akkomar commented 3 months ago

Should this become a required field in the schema? (probeinfo_api.yaml)

Seems like it should unless we want to repeat this process at some point.

whd commented 3 months ago

Should this become a required field in the schema? (probeinfo_api.yaml)

It probably should. If I set that to required will CI automatically fail if it's not specified?

At any rate, I want to land this as-is before making it required or adding a CI check since I deliberately skipped some apps that should be removed in the near future (rally).

badboy commented 3 months ago

Should this become a required field in the schema? (probeinfo_api.yaml)

It probably should. If I set that to required will CI automatically fail if it's not specified?

At any rate, I want to land this as-is before making it required or adding a CI check since I deliberately skipped some apps that should be removed in the near future (rally).

It should! And yeah, should have been explicit: landing this as a followup sounds good to me!