search

mozilla / probe-scraper

Scrape and publish Telemetry probe data from Firefox
https://mozilla.github.io/probe-scraper/
Mozilla Public License 2.0
21 stars 53 forks source link

Expire `user-characteristics` ping after 90 days (fixes #759) #778

Closed mozfreddyb closed 3 weeks ago

mozfreddyb commented 3 weeks ago

This adds a section for the user-characteristics ping in Firefox Desktop in repositories.yaml to ensure that data is retained for no longer than 90 days.

@sean-rose Please review :)

mozfreddyb commented 3 weeks ago

Aside: This is desktop only.

I'm trying to read between the lines what is left to be done, but if someone reviewing in here could help me to clearly identify if the user-characteristics ping is a also available mobile, we should probably add an expiration here too. I just didn't really get where I should be looking.. 😕

chutten commented 3 weeks ago

Aside: This is desktop only.

I'm trying to read between the lines what is left to be done, but if someone reviewing in here could help me to clearly identify if the user-characteristics ping is a also available mobile, we should probably add an expiration here too. I just didn't really get where I should be looking.. 😕

The Glean Dictionary'd give you what you wanted by looking at e.g. the list of Firefox for Android pings, but we can also look for where the ping is defined (toolkit/components/resistfingerprinting/pings.yaml) and see where that file is included in the dependency tree in repositories.yaml. It's in firefox_desktop's ping_files list, and that's an application so it's the root of its dependency tree, meaning that it's only ingested from applications using the firefox_desktop application id (which, you guessed it, is only Firefox Desktop).

So it's desktop-only.

The rule to follow would be to include the metadata about the ping's dataset's retention in the same application or library definition that has the file the ping's defined in in its ping_files list. Which you did!