search

mozilla / protocol-assets

Design assets for Protocol, Mozilla’s design system.
https://protocol.mozilla.org/
Mozilla Public License 2.0
12 stars 8 forks source link

Update Firefox Beta, Developer and Nightly logos (Fixes #30) #31

Closed alexgibson closed 5 years ago

alexgibson commented 5 years ago

@stephaniehobson good spot. The drop-shadow on the new logos doesn't seem to scale well at small sizes. Rather than play around with this, I decided it's probably better just to use some of the pre-exported sizes in the drive folder and update here using those. It seems to be better.

This does mean the logo sizes go from 100px -> 128px, and , 200px -> 256px but that's hopefully a minor bump in terms of bytes? I don't have Illustrator installed to play around with this further unfortunately.

stephaniehobson commented 5 years ago

R+ 📐 after the changelog update.

alexgibson commented 5 years ago

I think because the logo sizes have changed this needs a (breaking) warning and a full version bump. Consumers should check that they have defined sizes in their CSS and HTML where they have used existing logos.

Hmm, this is an odd one. I don't think this is likely going to risk breaking someone's build / deployment - but it could potentially make a logo appear slightly larger than usual on a web page, depending on how it's consumed. I'm inclined to say this could be a minor patch bump (adding a slightly larger image size but in a backward compatible way), so we'd bump it to 2.1.0.

Thoughts?

stephaniehobson commented 5 years ago

I'm more worried about If it's being used as a CSS background image without a background-size declaration with it.

But I don't want to over think this either!