mozilla / protocol-assets

Design assets for Protocol, Mozilla’s design system.
https://protocol.mozilla.org/
Mozilla Public License 2.0
11 stars 8 forks source link

Consider removing png assets for some logos? #62

Closed alexgibson closed 2 years ago

alexgibson commented 3 years ago

The NPM package that this repo publishes is now a whooping 28MB. I'm not sure if there's a limit to the size of an NPM package, but either way this is quite a lot of bandwidth to be pulling down every time Protocol gets built.

For some logo variations, such as Pocket and Mozilla VPN, I'm not sure of anywhere (at leasty on bedrock) where we don't use SVG today. The only real exception seems to be the Firefox logo, where a PNG can often compress smaller than an SVG.

This is open for discussion, but should we consider culling some of the more bandwidth heavy PNG variations that are not really well used? This of course would be a breaking change and a major version bump.

maureenlholland commented 3 years ago

Pausing work on https://github.com/mozilla/protocol-assets/issues/61 and https://github.com/mozilla/protocol-assets/issues/60 to do a quick audit on what PNGs we're actually using here.

Likely still need PNG for Firefox logo but VPN and Pocket could be SVG-only.

maureenlholland commented 3 years ago

Considering major breaking change to remove PNG assets for the following reasons:

To address before this change:

maureenlholland commented 2 years ago

Closed with https://github.com/mozilla/protocol-assets/pull/75