mozilla / protocol

A design system for Mozilla websites.
https://protocol.mozilla.org/
Mozilla Public License 2.0
260 stars 77 forks source link

Document the layout grid #413

Open craigcook opened 5 years ago

craigcook commented 5 years ago

Protocol currently has a very rudimentary proportional layout grid of quarters, thirds, and halves, but it's not documented. We need to remedy that and write docs both for the Sass mixins that define these widths, but moreover with general guidelines and examples for how to lay out elements.

This might also be a time to rethink our approach to the grid, though I still strongly feel we should avoid fixed grid units and should keep the layout fluid.

wboucherfischer commented 5 years ago

please see: https://docs.google.com/document/d/1NgIKryJ0dCoPOGqE5A6rFgjDomd-PuVuLulFhPkN3N8/edit?usp=sharing

Breakspoints are: 1312px desktop 1056px desktop/tablet landscape 768px tablet portrait 480px mobile bp 320px minimum mobile bp

stephaniehobson commented 5 years ago

FWIW we can still have a 12 column grid with a fluid layout.

wboucherfischer commented 5 years ago

Does it have to be a 12 column grid across all bps? I am just documenting what was created in the sticker sheet.

The 1312 bp was 12 columns. The 1056 bp was 12 columns. The 768 bp was 6 columns. The 480 bp and 320 bp was 2 columns.

@stephaniehobson what are we currently doing now?

stephaniehobson commented 5 years ago

I don't know what the designers are doing now, I have not been able to decern a pattern and do not get assets delivered with grid lines (maybe they're there but I don't know how to turn them on?) This would be a good question for the designers.

stephaniehobson commented 5 years ago

It should not be 12 on all breakpoints.

justinkropp commented 4 years ago

@stephaniehobson I'm working with @dzingeek on this to refine the content-widths and column structure of our grids. The breakpoints aren't changing, but there will be some updates to the grid organization. I'll post updates and visual assets here as soon as we get them finalized.

dzingeek commented 4 years ago

We have updated one breakpoint. 1056 is NOW 1024

https://github.com/mozilla/protocol-tokens/issues/71