mozilla / protocol

A design system for Mozilla websites.
https://protocol.mozilla.org/
Mozilla Public License 2.0
260 stars 77 forks source link

Audit use of vendor prefix mixins #957

Open janbrasna opened 3 months ago

janbrasna commented 3 months ago

There are a handful of utility mixins sometimes serving "interesting" prefixed rules:

https://github.com/mozilla/protocol/blob/12419244bf58ae0237edf062983c2852b56741e3/assets/sass/protocol/includes/mixins/_utils.scss#L101-L114

(e.g. align-items is unprefixed since Safari 9, and Safari 8 had it prefixed, but the fallback to *-box-align i.e. another experimental property sounds rather complex for today's use; -webkit-background-size had a different logic applied to param count and didn't understand a handful of values etc.)

While definitely intriguing piece of code that must have been really helpful in the past decade, some bits are probably no longer relevant or necessary, and if used, only inflating the compiled output with no positive impact. Maybe it's time to audit if/where these are being used, and plan a decommission path to have them removed one day.

If a major/breaking release is coming up, that might help justifying some of the mixin removal, if they no longer serve the purpose and would just need to be kept around passing through the stable property for backwards compatibility of the API.

amiii123malviya commented 3 months ago

Hello ,

I hope you are doing well,

Is this issue still active I would like work on this issue. Thankyou for your time , Looking forward for your response

Best Regards