search

mozilla / qbrt

CLI to a Gecko desktop app runtime
Apache License 2.0
390 stars 31 forks source link

refactor CLI code #107

Open mykmelez opened 7 years ago

cvan commented 6 years ago

long time no talk!

do you still need a review on this?

mykmelez commented 6 years ago

Hey @cvan, a review would be great! I'm especially interested in your thoughts on the architectural changes, and whether they'll make it easier (or harder) to maintain and enhance this code over time.

I've updated the branch to fix the conflict with master, so it's ready for your review!

cvan commented 6 years ago

@mykmelez awesome, sure thing!

do you have an idea what's wrong with the Taskcluster test failures on Windows? (I recall prior issues re: PR #69; same issue or different?)

mykmelez commented 6 years ago

do you have an idea what's wrong with the Taskcluster test failures on Windows? (I recall prior issues re: PR #69; same issue or different?)

I think this was a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1410564. I fixed it in https://github.com/mozilla/qbrt/commit/2b82e72747e1f9e361090c18a750f3cbb6a2ad2a, then resolved another Taskcluster failure on Windows, so the tests now pass there.