mozilla / r2d2b2g

Firefox OS Simulator is a test environment for Firefox OS. Use it to test your apps in a Firefox OS-like environment that looks and feels like a mobile phone.
https://addons.mozilla.org/en-US/firefox/addon/firefox-os-simulator/
Other
393 stars 139 forks source link

ADB `make test` fixes. Fixes #760 #775

Closed bkase closed 11 years ago

bkase commented 11 years ago

make test should now work on all platforms with or without a phone plugged in with or without ADB running in the background before starting the tests.

Unfortunately, I had to move the ADB tests into test-main.js in order to get everything to work (similar to #757). ADB was crashing in 8 different places non-deterministically on OSX (I just tested on OSX) when the tests were in a separate file (despite moving things around).

I grouped the tests in self-executing functions to make things private.

mykmelez commented 11 years ago

This is very unfortunate, but I'd rather have working tests than perfectly structured test files.