search

mozilla / r2d2b2g

Firefox OS Simulator is a test environment for Firefox OS. Use it to test your apps in a Firefox OS-like environment that looks and feels like a mobile phone.
https://addons.mozilla.org/en-US/firefox/addon/firefox-os-simulator/
Other
392 stars 139 forks source link

Bug 925765 - Enable rotation button back #863

Closed ochameau closed 10 years ago

ochameau commented 10 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=925765

jryans commented 10 years ago

I tried this out on OS X 10.8, but it doesn't appear to work. When I click the rotation button, nothing happens.

I remember there being Mac-specific complexities when this was converted from XUL to HTML, perhaps that is related?

mykmelez commented 10 years ago

The code looks reasonable, but there are still a couple of issues with the experience.

First, one can only rotate the view 90º in one direction, which was fine when only orientable apps were experiencing rotation. But now that all apps experience rotation, and non-orientable apps like Homescreen turn sideways, it seems likely that users will split between wanting to see those sideways apps pointing in one direction vs. the other. So we should enable that (perhaps by making each successive click of the button cause the view to rotate another 90º in the same direction).

Second, if you're in an orientable app (like Marketplace), and you rotate the screen to landscape, and then you return to the Homescreen, the rotation changes back to portrait. I would expect it to stay rotated.

I'd prefer to address these experience issues before landing the change, but in any case this is a big improvement, so I'm ok with landing it and then iterating on the details.

mykmelez commented 10 years ago

Looks good, r=myk!