search

mozilla / r2d2b2g

Firefox OS Simulator is a test environment for Firefox OS. Use it to test your apps in a Firefox OS-like environment that looks and feels like a mobile phone.
https://addons.mozilla.org/en-US/firefox/addon/firefox-os-simulator/
Other
392 stars 139 forks source link

Update adb - deprecate #879

Closed ochameau closed 10 years ago

ochameau commented 10 years ago
mykmelez commented 10 years ago

This looks reasonable, but we haven't shipped the 5.0 release yet, and it isn't yet ready for release. So I think we should make these changes to the 4.0 codebase and ship a 4.0.1 with them.

(We should probably also decide that we're not going to ship 5.0, assuming that there are few developers on older versions of Firefox, so it isn't worth completing that work, and we should focus instead on shipping libadb in the ADB Helper addon for the App Manager than in an updated version of the classic addon for older Firefoxes.)

ochameau commented 10 years ago

You're right, the (bad) reason I based on 5.0 is that, we only have a 5.0 branch that I can pull request to. I'll rebase that patch against https://github.com/mozilla/r2d2b2g/releases/tag/4.0 and create a 4.0 branch. Is it the right revision I should target?

mykmelez commented 10 years ago

You're right, the (bad) reason I based on 5.0 is that, we only have a 5.0 branch that I can pull request to. I'll rebase that patch against https://github.com/mozilla/r2d2b2g/releases/tag/4.0 and create a 4.0 branch. Is it the right revision I should target?

Yes, that's the right revision!

ochameau commented 10 years ago

Closing in favor of https://github.com/mozilla/r2d2b2g/pull/881