I think it makes sense to set up CI for redash-ui-tests (#2) and run the tests against a stable version of Redash and see if all tests - old and new - still pass. This way we know if tests are safe to be merged here.
Running tests against Redash
We also want to think about how to integrate redash-ui-tests into the developer workflow for Redash. I think it's up to the maintainers of the projects how to implement that, but we should make it as easy as possible for them to run the UI tests and write documentation here with an example implementation.
I suggest we push a Docker image of redash-ui-tests on successful CI builds on master. This image would need to support passing in a URI to Redash and an entrypoint to run the tests. The Redash projects can pull that redash-ui-tests image and run it for pull-requests and release-candidate branches.
b4handjr
commented
6 years ago
Updates to tests
I think it makes sense to set up CI for redash-ui-tests (#2) and run the tests against a stable version of Redash and see if all tests - old and new - still pass. This way we know if tests are safe to be merged here.
Running tests against Redash
We also want to think about how to integrate redash-ui-tests into the developer workflow for Redash. I think it's up to the maintainers of the projects how to implement that, but we should make it as easy as possible for them to run the UI tests and write documentation here with an example implementation.
Suggestions
Both upstream Redash and Mozilla Redash publish the Redash server image to Docker Hub and use docker-compose.
I suggest we push a Docker image of redash-ui-tests on successful CI builds on master. This image would need to support passing in a URI to Redash and an entrypoint to run the tests. The Redash projects can pull that redash-ui-tests image and run it for pull-requests and release-candidate branches.