search

mozilla / redash

This is a Mozilla fork of the re:dash project (https://redash.io/), where we do work to be contributed back to the upstream project and for our own custom needs.
BSD 2-Clause "Simplified" License
20 stars 21 forks source link

Don't immediately remove notifications from notification trays (backport getredash#4773) #1002

Closed mnoorenberghe closed 4 years ago

mnoorenberghe commented 4 years ago

Let the notifications go into browser/OS notification trays so users can click on them from there if they miss the initial notification. Modern browsers generally use OS notifications so the user is in control of the notification at the OS level. The current 3s delay isn't a good UX and is quite frustrating when I have multiple monitors and windows and can't find the query that finished easily.

This is a trivial backport of https://github.com/getredash/redash/pull/4773 which was merged to master upstream.

It wasn't clear which branch I was supposed to use in our Mozilla fork but I think release is correct.

mnoorenberghe commented 4 years ago

The test failure seems to be caused by a network issue from apt installing packages and unrelated to my PR.

jezdez commented 4 years ago

Thanks for the PR @mnoorenberghe, this is indeed useful and I'm glad you were able to fix it upstream. We're pulling in those changes from upstream in #1003 and deploy this soon (after testing). I'm closing this for now since it's not needed as a separate PR. Thank you again for your help!