search

mozilla / redash

This is a Mozilla fork of the re:dash project (https://redash.io/), where we do work to be contributed back to the upstream project and for our own custom needs.
BSD 2-Clause "Simplified" License
21 stars 21 forks source link

Mousing over table names shows “{{item.name}}” instead of the table name #1007

Open zachliu opened 4 years ago

zachliu commented 4 years ago

Issue Summary

Mousing over table names shows “{{item.name}}” instead of the table name

Steps to Reproduce

  1. Mouse over any table in the schema list
  2. Then you see the incorrect infotip "{{item.name}}".

Technical details:

zachliu commented 4 years ago

Found the :bug:! This line https://github.com/mozilla/redash/blob/1d31c6315d1190c3d68f3dc7dd1a1ab91daa6f39/client/app/pages/queries/components/SchemaBrowser.jsx#L53

should be

        <span title={`${item.name}`}>{item.name}</span>

or

        <span title={item.name}>{item.name}</span>

depending on whether we want string interpolation or not