search

mozilla / redash

This is a Mozilla fork of the re:dash project (https://redash.io/), where we do work to be contributed back to the upstream project and for our own custom needs.
BSD 2-Clause "Simplified" License
20 stars 21 forks source link

M31 rebase #1014

Open jezdez opened 4 years ago

jezdez commented 4 years ago

This m31-rebase branch contains the almost working rebase on top of a recent-ish version of Redash.

I'm having trouble fixing the schema drawer integration into the data source edit interface and I wonder if you had time to look at it @emtwo?

I'm getting this error:

Warning: Failed prop type: The prop `record.key` is marked as required in `EditableCell`, but its value is `undefined`.
    in EditableCell (created by Cell)

when editing a data source locally.

CleanShot 2020-10-15 at 15 36 33@2x
emtwo commented 4 years ago

This m31-rebase branch contains the almost working rebase on top of a recent-ish version of Redash.

I'm having trouble fixing the schema drawer integration into the data source edit interface and I wonder if you had time to look at it @emtwo?

I'm getting this error:

Warning: Failed prop type: The prop `record.key` is marked as required in `EditableCell`, but its value is `undefined`.
    in EditableCell (created by Cell)

when editing a data source locally.

CleanShot 2020-10-15 at 15 36 33@2x

Thanks for doing the rebase, Jannis! I will try to take a look today or if not, tomorrow. Just wondering, does the page not load at all? What else happens aside from seeing the error? Thanks!

jezdez commented 4 years ago

@emtwo thank you! the page loads, and I can see the datasource edit form, but for some reason I can't update any of the columns metadata, the form input can't be selected

emtwo commented 4 years ago

@jezdez I pushed my in-progress commit where I've updated the schema table based on the example of editable tables made by antd here: https://ant.design/components/table/#components-table-demo-edit-row

It's kind of in a rough state right now unfortunately. It loads and you can type in the description when you hit edit (that's an improvement over what was there before!) But saving doesn't work yet.

I think the example in the link should hopefully be helpful enough to get the rest of it sorted out. Let me know if there is anything else I can help with.