search

mozilla / release-services

Mozilla Release Engineering Services
https://docs.mozilla-releng.net
Mozilla Public License 2.0
49 stars 93 forks source link

shipit: support multiple builds per branch #2056

Closed rail closed 5 years ago

rail commented 5 years ago

@JohanLorenzo what do you think?

JohanLorenzo commented 5 years ago

Thanks a lot, @rail for putting this PR up so quickly 😃 The patch and the UI (testing on staging) look good to me overall 👍 I'm close to test this end-to-end, but I can across this error when I tried to schedule the promote_fennec_beta graph. That looks expected. Where should the new scopes added? 

Error: required permission: project:releng:services/shipit_api/schedule_phase/fennec/promote_fennec_beta, user permissions: project:releng:services/shipit_api/add_release/firefox, project:releng:services/shipit_api/abandon_release/firefox, project:releng:services/shipit_api/schedule_phase/firefox/ship_firefox_rc, project:releng:services/shipit_api/phase_signoff/firefox/ship_firefox_rc, project:releng:services/shipit_api/schedule_phase/firefox/push_firefox, project:releng:services/shipit_api/phase_signoff/firefox/push_firefox, project:releng:services/shipit_api/schedule_phase/firefox/promote_firefox, project:releng:services/shipit_api/phase_signoff/firefox/promote_firefox, project:releng:services/shipit_api/schedule_phase/firefox/promote_firefox_rc, project:releng:services/shipit_api/phase_signoff/firefox/promote_firefox_rc, project:releng:services/shipit_api/schedule_phase/firefox/ship_firefox, project:releng:services/shipit_api/phase_signoff/firefox/ship_firefox, project:releng:services/shipit_api/add_release/fennec, project:releng:services/shipit_api/abandon_release/fennec, project:releng:services/shipit_api/schedule_phase/fennec/ship_fennec_rc, project:releng:services/shipit_api/phase_signoff/fennec/ship_fennec_rc, project:releng:services/shipit_api/schedule_phase/fennec/promote_fennec, project:releng:services/shipit_api/phase_signoff/fennec/promote_fennec, project:releng:services/shipit_api/schedule_phase/fennec/ship_fennec, project:releng:services/shipit_api/phase_signoff/fennec/ship_fennec, project:releng:services/shipit_api/add_release/devedition, project:releng:services/shipit_api/abandon_release/devedition, project:releng:services/shipit_api/schedule_phase/devedition/push_devedition, project:releng:services/shipit_api/phase_signoff/devedition/push_devedition, project:releng:services/shipit_api/schedule_phase/devedition/promote_devedition, project:releng:services/shipit_api/phase_signoff/devedition/promote_devedition, project:releng:services/shipit_api/schedule_phase/devedition/ship_devedition, project:releng:services/shipit_api/phase_signoff/devedition/ship_devedition, project:releng:services/shipit_api/add_release/thunderbird, project:releng:services/shipit_api/abandon_release/thunderbird, project:releng:services/shipit_api/schedule_phase/thunderbird/ship_thunderbird, project:releng:services/shipit_api/phase_signoff/thunderbird/ship_thunderbird, project:releng:services/shipit_api/schedule_phase/thunderbird/push_thunderbird, project:releng:services/shipit_api/phase_signoff/thunderbird/push_thunderbird, project:releng:services/shipit_api/schedule_phase/thunderbird/promote_thunderbird, project:releng:services/shipit_api/phase_signoff/thunderbird/promote_thunderbird, project:releng:services/shipit_api/sync_releases, project:releng:services/shipit_api/rebuild_product_details, project:releng:services/shipit_api/sync_release_datetimes, project:releng:services/shipit_api/update_release_status
rail commented 5 years ago

Let me push to staging to see if the fix works as expected.