search

mozilla / release-services

Mozilla Release Engineering Services
https://docs.mozilla-releng.net
Mozilla Public License 2.0
49 stars 93 forks source link

shipit/api: export Devedtion version #2111

Closed rail closed 5 years ago

rail commented 5 years ago

First 2 Devedition releases are released before betas. In this case we try to run sanity checks using the latest devedtion version against versions in firefox_primary_builds.json, which doesn't explicitly contain devedition versions. The sanity check fails with Too few firefox primary builds for FIREFOX_DEVEDITION.

The patch adds FIREFOX_DEVEDITION to the list of versions used in firefox_primary_builds.json using set sowe don't duplicate entries.

This also means that sometimes we may have multiple entries with beta version pattern in firefox_primary_builds.json. Per our chat with pmac, this shouldn't be an issue. We have something similar when we ship 2 ESR releases at the same time.

pmac commented 5 years ago

Looks good to me 💯 Thanks for the quick work!

rail commented 5 years ago

I tested this, should be safe to land