search

mozilla / release-services

Mozilla Release Engineering Services
https://docs.mozilla-releng.net
Mozilla Public License 2.0
49 stars 93 forks source link

Bug 1554046 - Let ship-it use the Fennec new version files #2144

Closed JohanLorenzo closed 5 years ago

JohanLorenzo commented 5 years ago

r? @rail

I didn't find a way to add tests. What's the way to do so?

rail commented 5 years ago

I was thinking about using the configs to explicitly defining version files. I'd add something like versionFile: 'mobile/..../version_display.txt' to this config and use it in the calculations. The same for all other products. This way we don't try to guess and riding the trains is easier.

What do you think?

JohanLorenzo commented 5 years ago

Sure! Something like this?

rail commented 5 years ago

Perfect! Let's deploy it to staging tomorrow or later today (it's closed atm).

Thank you for taking this!