search

mozilla / release-services

Mozilla Release Engineering Services
https://docs.mozilla-releng.net
Mozilla Public License 2.0
49 stars 93 forks source link

ESLint errors failed to report to Phabricator UI #2162

Closed Standard8 closed 5 years ago

Standard8 commented 5 years ago

I was applying https://phabricator.services.mozilla.com/D33798 for test locally, and was surprised to see a relatively amount of ESLint failures listed locally.

The link to the source code analysis said that it passed: https://phabricator.services.mozilla.com/harbormaster/build/102283/

However the link to treeherder clearly shows ESLint as failing:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=45fcb0e6e9db380b8aa93170c41403007a4e5b8d

La0 commented 5 years ago

The eslint task did not produce a JSON artifact. There should be a public/code-review/mozlint.json here.

Our publication task detected that the file was missing, but did not crash. @marco-c Maybe we should simply crash the review task or post an error on phabricator warning the developer that an analyzer was not processed ?

marco-c commented 5 years ago

Why was the artifact missing? Adding a warning makes sense to me, unless this is a very rare occurrence and we can fix the underlying problem easily.

La0 commented 5 years ago

I just noticed that the eslint command misses the json output argument on CLI !

It's weird because it's still present on MC

This definitely should not happen.

marco-c commented 5 years ago

So probably this is just because the patch was based on a old revision of mozilla-central: https://hg.mozilla.org/try/file/45fcb0e6e9db380b8aa93170c41403007a4e5b8d/taskcluster/ci/source-test/mozlint.yml#l68.