search

mozilla / release-services

Mozilla Release Engineering Services
https://docs.mozilla-releng.net
Mozilla Public License 2.0
49 stars 93 forks source link

Centralize version parsing in mozilla-version 0.4.x #2231

Closed JohanLorenzo closed 5 years ago

JohanLorenzo commented 5 years ago

r? @rail

rail commented 5 years ago

This is awesome! thank you! Let me test this a bit.

JohanLorenzo commented 5 years ago

Thanks for testing it out! I implement a slightly different fix because some other places do rely on product to be a string, if I understand correctly

Tell me what you think, @rail :)

JohanLorenzo commented 5 years ago

Note: this PR will facilitate https://bugzilla.mozilla.org/show_bug.cgi?id=1562629

rail commented 5 years ago

Let's deploy it after the release, in a couple of days.

lundjordan commented 5 years ago

@JohanLorenzo we don't know the root cause but rail pointed out that the partial condition check for determining if rc got moved out by one scope: https://github.com/mozilla/release-services/pull/2231/files#diff-ae9b2045812d1ad31281348eea2154a3R71

we saw today's beta become an 'rc' in shipit.

rail commented 5 years ago

We should probably just return early from that function, something like

if not gecko_version.is_release or gecko_version.patch_number is not None:
    return False