[shipit] There is no suggested revision, nor error message when the last commits of a repository are all DONTBUILD

mozilla / release-services

Mozilla Release Engineering Services

https://docs.mozilla-releng.net

Mozilla Public License 2.0

49 stars 93 forks source link

[shipit] There is no suggested revision, nor error message when the last commits of a repository are all DONTBUILD #2235

Open JohanLorenzo opened 5 years ago

JohanLorenzo commented 5 years ago

It happened today with ESR68. @pascalchevrel and I were really confused. Nothing came up:

After some investigation, these lines are filtering all commits out:
https://github.com/mozilla/release-services/blob/46637c7198c64e36369e317fdab173bbaccd8609/src/shipit/frontend/src/views/NewRelease/index.js#L71-L73

I think we should show a warning explaining why nothing comes up.

What do you think @rail ?

rail commented 5 years ago

We definitely should warn when the list of suggestions is empty. Or maybe we can fetch more pushes in this case. Another option would be listing the DONTBUILD pushes, but make them not selectable.