Closed lundjordan closed 5 years ago
context:
wsmwk> mhentges: i'm getting an auth failure in shipit trying to "start tracking" for thunderbird bhearsum> i found the exception for the thunderbird issue: https://gist.github.com/mozbhearsum/2ab0ceadf1122c18140ff16b75916bfa closemozbhearsum — 8 Aug 2019 13:22:52 <•bhearsum> (it was on Sentry, for those with acccess: https://sentry.prod.mozaws.net/operations/mozilla-releng-services/issues/6127311/?query=is:unresolved%20is:unassigned) 14:47:32 <•jlund> should thunderbird have an rc flavour? Does it push release builds to beta first? 14:47:37 it's not in https://github.com/mozilla/release-services/blob/4567698690d6cce5bf2a685c04021774125294cd/src/shipit/api/shipit_api/config.py#L432 14:47:45 but code thinks it should be: https://github.com/mozilla/release-services/blob/eabe5ca63fbe1e5bea48c1c450e0cce72b1309e4/src/shipit/api/settings.py#L137 14:49:44 whens the last time we did a thunderbird release on the release channel? this is 6month old code.. 14:51:23 <•aki> good questions. beta and esr only maybe? (i am not the expert) 14:52:19 <•jlund> oh, actually I think this is the bug: https://github.com/mozilla/release-services/pull/2181/files 14:54:07 because is_rc() is assuming if the release is not a dot release, it's an rc, even for thunderbird 14:54:08 https://github.com/mozilla/release-services/blob/e3ca5565c4108e76d33cfd2dedec20248dcfc58f/src/shipit/api/shipit_api/release.py#L61 14:54:21 <•aki> aha. maybe is_rc should take product as well 14:54:34 <•jlund> ++ 14:55:03 — •jlund writes a patch
context:
wsmwk> mhentges: i'm getting an auth failure in shipit trying to "start tracking" for thunderbird bhearsum> i found the exception for the thunderbird issue: https://gist.github.com/mozbhearsum/2ab0ceadf1122c18140ff16b75916bfa closemozbhearsum — 8 Aug 2019 13:22:52 <•bhearsum> (it was on Sentry, for those with acccess: https://sentry.prod.mozaws.net/operations/mozilla-releng-services/issues/6127311/?query=is:unresolved%20is:unassigned) 14:47:32 <•jlund> should thunderbird have an rc flavour? Does it push release builds to beta first? 14:47:37 it's not in https://github.com/mozilla/release-services/blob/4567698690d6cce5bf2a685c04021774125294cd/src/shipit/api/shipit_api/config.py#L432 14:47:45 but code thinks it should be: https://github.com/mozilla/release-services/blob/eabe5ca63fbe1e5bea48c1c450e0cce72b1309e4/src/shipit/api/settings.py#L137 14:49:44 whens the last time we did a thunderbird release on the release channel? this is 6month old code.. 14:51:23 <•aki> good questions. beta and esr only maybe? (i am not the expert) 14:52:19 <•jlund> oh, actually I think this is the bug: https://github.com/mozilla/release-services/pull/2181/files 14:54:07 because is_rc() is assuming if the release is not a dot release, it's an rc, even for thunderbird 14:54:08 https://github.com/mozilla/release-services/blob/e3ca5565c4108e76d33cfd2dedec20248dcfc58f/src/shipit/api/shipit_api/release.py#L61 14:54:21 <•aki> aha. maybe is_rc should take product as well 14:54:34 <•jlund> ++ 14:55:03 — •jlund writes a patch