mozilla / releases-comm-central

EXPERIMENTAL - copy of comm-central for forking on github
162 stars 96 forks source link

Bug: Default `ignoreProps` array is missing `X-MOZ-LASTACK` and `X-MOZ-GENERATION` #94

Open titanism opened 6 months ago

titanism commented 6 months ago

Per https://github.com/mozilla/releases-comm-central/blob/2e0cd2b03bea7839120f79db06476733e964e5ae/calendar/base/modules/utils/calItemUtils.sys.mjs#L407-L417 the following two properties need added:

The change would look like this:

  compareContent(aFirstItem, aSecondItem, aIgnoreProps, aIgnoreParams) {
    const ignoreProps = arr2hash(
      aIgnoreProps || [
        "SEQUENCE",
        "DTSTAMP",
        "LAST-MODIFIED",
        "X-MOZ-GENERATION",
        "X-MICROSOFT-DISALLOW-COUNTER",
        "X-MOZ-SEND-INVITATIONS",
        "X-MOZ-SEND-INVITATIONS-UNDISCLOSED",
+        "X-MOZ-LASTACK",
+        "X-MOZ-GENERATION",
      ]
    );

A simple diff using diff -u a.ics b.ics | diff-so-fancy of a calendar synchronization of ICS files shows that these two properties are the only ones that change outside the ignored ones:

Screen Shot 2024-02-27 at 3 46 57 PM
titanism commented 6 months ago

Adding this might actually cause errors with generation mismatch.