search

mozilla / releases_insights

Parse various sources (hg log, apis, crashes…) to get some insights on past releases such as uplifts per beta, top crash signatures per nightly…
Mozilla Public License 2.0
25 stars 8 forks source link

Try composer-patches 2.x? #61

Open cweagans opened 6 days ago

cweagans commented 6 days ago

Hi there! I see that you're using composer-patches. A 2.x release is imminent and I would love your feedback on the new version prior to tagging a final release. From what I can see in your composer.json, the new release should Just Work (tm), but if it doesn't, I'm happy to help troubleshoot.

pascalchevrel commented 5 days ago

@cweagans Hi, I just tried 2.0.0-beta2, here is my feedback;

  1. I use symplify/vendor-patches to generate the patches and it is not yet compatible, so I removed it. You may want to reach out to the author to make sure it will be updated.

  2. After removing symplify/vendor-patches and installing 2.0.0-beta2, it fails to apply the patch with this message:

  • Patching benhall14/php-calendar
    • Found cached patch at /home/pascal/.cache/composer/patches/ffd51a2d0b37eec2cacd1d0f9d57a41cd30851ada67334f4ce70e6fc007cecc8.patch

In Patches.php line 288:

No available patcher was able to apply patch patches/benhall14-php-calendar-html-css-calendar-css.patch to benhall14/php-calendar

image

  1. Since it failed to install a cached file, I tried composer install --no-cache but in this case the install process ends up with this error:
  • Patching benhall14/php-calendar

In Downloader.php line 31:

mkdir(): Not a directory

image

(In all of my tests, I deleted the vendor folder before doing a composer install)

cweagans commented 5 days ago

Well that's not great :) I'll look into it. Thank you for testing!