search

mozilla / releasewarrior

Similar to the definition of a Census, this tool systematically acuires and records information about the releases of a given product
9 stars 16 forks source link

Update release promotion how to for signoffs process #83

Closed bhearsum closed 7 years ago

bhearsum commented 7 years ago

This is a first crack at updating the docs to reflect the incoming multiple signoffs process. There's two main parts here: 1) Add a new "signoffs" section with a guide on how to do it in Balrog. 2) Update the "publish release" section to reflect the fact that the Balrog publishing will happen automatically.

Note that the current instructions talk about RelMan doing signoff for all Betas. This probably needs to change to reflect the reality that QE does signoff for non-RC or Beta 1 Betas. I'll update this once I figure out exactly how that will work. In the meantime, I'm hoping to get some feedback on the contents themselves and whether or not this is the right place for the signoff guide. I considered putting a more generic guide to signoffs in the Balrog documentation, but I thought that it would be more useful to have one that reflected the exact process we use for releases here.

@rail @lundjordan - I think you're probably the best people to look at this from the RelEng side? And probably @rkothari19 from RelMan. I'm happy to have any other comments too, though.

It's probably easiest to review this by looking at the new page, which as the screenshots embedded into the doc: https://github.com/mozbhearsum/releasewarrior/blob/multiple-signoffs/how-tos/relpro.md.

bhearsum commented 7 years ago

@lundjordan and I talked about this a bit more today and decided it made sense to a checkbox for the signoff steps, since it is very similar to other things that have one (requires a manual step done elsewhere). I'll be doing that, and addressing the other feedback.

bhearsum commented 7 years ago

@lundjordan - I think the latest updates address all of your comments

bhearsum commented 7 years ago

Ritu approved this by e-mail, so we're OK from the RelMan side.

bhearsum commented 7 years ago

Latest update is to include the fact that QE is expected to be part of the signoff process now.

bhearsum commented 7 years ago

@lundjordan - can you have another look at this when you have time?

lundjordan commented 7 years ago

yep. sorry for delay. I'll make sure to review this before EOD tomorrow, wed.

lundjordan commented 7 years ago

This looks good by eye! Thanks for adding the signoff action. Did you test it out locally?

I guess since we are not adding an actual option, we have to use --checkbox ?? Which is fine, perhaps we should remove all options and force --checkbox as the only way to update via cmdline. But that sounds outside this scope and belongs as a separate issue.

bhearsum commented 7 years ago

This looks good by eye! Thanks for adding the signoff action. Did you test it out locally?

I didn't.

I guess since we are not adding an actual option, we have to use --checkbox ?? Which is fine, perhaps we should remove all options and force --checkbox as the only way to update via cmdline. But that sounds outside this scope and belongs as a separate issue.

Oh, I thought this is what you were suggesting. If it's preferred, I could add a proper command (I assume you mean something like the "create" or "update" command).

lundjordan commented 7 years ago

I mislead you. You are right and this is good.

If you are curious about my confusion: I shouldn't have used the word action on irc. I meant human action, which used to be modified by option args in warrior. Previously you could either do release update --$human_action or release update --checkbox $human_action. They were equivalent. I thought you were missing the former but I didn't realize till today that we got rid of --$human_action altogether.

I tried this out locally and it works as expected. For that reason, I'll merge this in on your behalf. Looks great. Thanks for adding it in yourself.