search

mozilla / releasewarrior

Similar to the definition of a Census, this tool systematically acuires and records information about the releases of a given product
9 stars 16 forks source link

Add 'signoff' to all human task definitions. #90

Closed bhearsum closed 7 years ago

bhearsum commented 7 years ago

@MihaiTabara discovered issues with my updates for multiple signoffs that lead to the backing out of #83. It boiled down to the fact that the markdown templates were looking for a "signoff" human task, but it didn't exist in many of the json files they depended on. I believe the issue boils down to the fact that the json files for active releases at the time were generated without "signoff" being a valid human decision task, and when the .md files are regenerated based on the new templates (which have references to a "signoff" human step), they fail.

To work around this, I think we should do a two stage landing of my original PR. This first landing will update config.py and all of the JSON templates. Once all of the active releases have the "signoff" human task in them, we can land part 2, which will update the .md templates and the docs.

lundjordan commented 7 years ago

yeah, sorry about that. design limitation.