Assure jshint checks all directories

mozilla / remote-newtab

Remotely-hosted New Tab Page

https://mozilla.github.io/remote-newtab/src/

Mozilla Public License 2.0

15 stars 7 forks source link

Assure jshint checks all directories #132

Closed marcoscaceres closed 9 years ago

marcoscaceres commented 9 years ago

@k88hudson r? This catches everything now, but can you think of a more reliable way of doing this? It's not great that we have to list all the directories... maybe we need to bug the jshint maintainers to fix globbing.

k88hudson commented 9 years ago

Weird, I'm seeing an identical file list being generated with both your patch and the existing command (with the exception of js/src/sw.js, which your patch is missing ATM)

What files are you seeing being missed with the existing command?

oyiptong commented 9 years ago

I saw that behavior on ursula's computer. The commands executed were not the ones In package.json until npm install is run.

The original command seems to run fine for me.

Can you please try to run npm install?

marcoscaceres commented 9 years ago

@oyiptong, @k88hudson ok, re-ran install. Works. Sorry for wasting time.