search

mozilla / remote-newtab

Remotely-hosted New Tab Page
https://mozilla.github.io/remote-newtab/src/
Mozilla Public License 2.0
15 stars 7 forks source link

Fetch 1l0n strings and save them locally (l10n part 1) #138

Closed marcoscaceres closed 8 years ago

marcoscaceres commented 8 years ago

This is the first of a batch of commits related to l10n. This one downloads the string files, processes them into JSON files, which we will then consume in various ways (coming in next batch set).

marcoscaceres commented 8 years ago

(updated comment above)

@oyiptong r?

oyiptong commented 8 years ago

r+ with some nits. Good stuff!

marcoscaceres commented 8 years ago

Ok, updated to using Maps... ironically, you still need to JSON.parse() text into an object in order for the JSON.stringifier()'s object formatter to work (because it expects an object!)... so, lols :hankey:.

oyiptong commented 8 years ago

Ugh... I suppose I understand why Maps aren't JSON serializable... I somehow wish that we could bury out heads in the sand with objects as maps lol.