mozilla / remote-newtab

Remotely-hosted New Tab Page
https://mozilla.github.io/remote-newtab/src/
Mozilla Public License 2.0
15 stars 7 forks source link

Service workers #160

Closed rlr closed 8 years ago

rlr commented 8 years ago

here it is again. r?

rlr commented 8 years ago

I am not sure what's up with the tests. Are they supposed to work in this branch?

$ npm test

> newtab@0.0.0 test /Users/rlr/dev/remote-newtab
> npm run karma

> newtab@0.0.0 karma /Users/rlr/dev/remote-newtab
> karma start --single-run

sh: karma: command not found

npm ERR! Darwin 15.2.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "karma"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! newtab@0.0.0 karma: `karma start --single-run`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the newtab@0.0.0 karma script 'karma start --single-run'.
npm ERR! This is most likely a problem with the newtab package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     karma start --single-run
npm ERR! You can get their info via:
npm ERR!     npm owner ls newtab
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/rlr/dev/remote-newtab/npm-debug.log
npm ERR! Test failed.  See above for more details.
rlr commented 8 years ago

^ I updated the service worker to use the list of static files from mainSiteURLs.json

rlr commented 8 years ago

ok. i moved the build:offline back. I think it's fine.. Only when debugging the service worker would we need to do a full build before starting the dev server. Fixed the logging too

k88hudson commented 8 years ago

YAY! this is looking awesome! R+