search

mozilla / remote-newtab

Remotely-hosted New Tab Page
https://mozilla.github.io/remote-newtab/src/
Mozilla Public License 2.0
15 stars 7 forks source link

Page direction #184

Closed sarracini closed 8 years ago

sarracini commented 8 years ago

@k88hudson @oyiptong r?

k88hudson commented 8 years ago

I think since we're in firefox only :-moz-dir(rtl) is ok but a bit dangerous to enforce this strategy, since you have to remember to do it every time you add a margin-left etc. etc.

We might want to consider using something like this instead, and have a compile step: https://www.npmjs.com/package/cssjanus

What do you think?

k88hudson commented 8 years ago

The other stuff you have in this patch is :+1:, I'm just wondering about the css strategy

k88hudson commented 8 years ago

@sarracini let's just squash/merge for now and file a follow-up for using a different RTL strategy

k88hudson commented 8 years ago

R+

sarracini commented 8 years ago

Filed follow-up: https://github.com/mozilla/remote-newtab/issues/189