search

mozilla / remote-newtab

Remotely-hosted New Tab Page
https://mozilla.github.io/remote-newtab/src/
Mozilla Public License 2.0
15 stars 7 forks source link

Index DB for pinned links. #74

Closed emtwo closed 9 years ago

emtwo commented 9 years ago
emtwo commented 9 years ago

r? @sarracini or @oyiptong or @marcoscaceres

oyiptong commented 9 years ago

can you please write some tests for both modules?

emtwo commented 9 years ago

@marcoscaceres, I wanted to get your opinion on this. _setSimpleRequestHandlers(), _onDatabaseOpenSuccess(), and _onWriteFetchRequestSuccess() are still receiving resolve or reject as params. I kept these because they make the code more concise and readable in my opinion. Do you still think it's better to embed these functions so that we don't need to pass them resolve or reject?

emtwo commented 9 years ago

r? @marcoscaceres, @sarracini, @oyiptong

Also, if anyone knows why coveralls seems to be hanging or how to debug it, please let me know :)

Edit: Please ignore review request for now, making more changes.

oyiptong commented 9 years ago

@emtwo you can click on the link: https://coveralls.io/builds/3568624

oyiptong commented 9 years ago

there's a couple of untested error conditions: https://coveralls.io/builds/3568624/source?filename=js%2FuserDatabase.js

emtwo commented 9 years ago

r? @marcoscaceres

emtwo commented 9 years ago

@marcoscaceres I've addressed all your comments (I think) please let me know if this looks good. Thanks!

marcoscaceres commented 9 years ago

r+

marcoscaceres commented 9 years ago

Nice work :smile_cat: