search

mozilla / rhino

Rhino is an open-source implementation of JavaScript written entirely in Java
https://rhino.github.io
Other
4.18k stars 851 forks source link

FIX: Evaluation of ?? #1624

Closed 0xe closed 2 months ago

0xe commented 2 months ago

Fixes #1623

p-bakker commented 2 months ago

Assume this isn't covered by any test from test262?

p-bakker commented 2 months ago

Looks like the pipeline fails due to some failing tests

0xe commented 2 months ago

Assume this isn't covered by any test from test262?

Yeah, this isn't covered. Will raise a PR against 262 to add this scenario.

0xe commented 2 months ago

Looks like the pipeline fails due to some failing tests

I'm working on fixing those.

p-bakker commented 2 months ago

Besides that minor comment this LGTM

gbrail commented 2 months ago

Looks good to me too. Thanks!