mozilla / rhino

Rhino is an open-source implementation of JavaScript written entirely in Java
https://rhino.github.io
Other
4.18k stars 851 forks source link

Optimize performance in test262 #1671

Closed rPraml closed 1 month ago

rPraml commented 1 month ago

This PR targets two issues I found with a profiler, while running the 262 test suite:

rbri commented 1 month ago

NativeJavaListTest > length FAILED org.junit.ComparisonFailure at NativeJavaListTest.java:161

RegexpTest > unsupportedFlagCtor FAILED org.junit.ComparisonFailure at RegexpTest.java:71

rPraml commented 1 month ago

Fixed the condition in the "filter"method. Now ShellTimerTest fails. Waiting for #1672, then I'll do a rebase

rbri commented 1 month ago

@rPraml #1672 is merged go ahead :-)

rbri commented 1 month ago

@rPraml thanks for that, faster tests are always a good thing