Convert NativeArrayBuffer, NativeDataView, and TypedArrays to lambda

mozilla / rhino

Rhino is an open-source implementation of JavaScript written entirely in Java

https://rhino.github.io

Other

4.19k stars 851 forks source link

Convert NativeArrayBuffer, NativeDataView, and TypedArrays to lambda #1709

Closed camnwalter closed 4 weeks ago

camnwalter commented 1 month ago

This PR converts the ArrayBuffer and adjacent classes to using LambdaConstructor.

I haven't added any new functionality, just a basic conversion from IdScriptable to using lambdas. Hopefully will get to adding more correct functionality in the future...

This should fix these inside #963 :

TypedArray.buffer/byteLength/byteOffset
DataView.buffer/byteLength/byteOffset
ArrayBuffer.byteLength as they should all be accessor properties now.

camnwalter commented 1 month ago

Rebased on master

Will fix issues..

gbrail commented 4 weeks ago

Thanks -- this looks good!